Skip to content

Implement unique selection reduction #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
luseverin wants to merge 42 commits into
base: forecast-class
Choose a base branch
from
Draft

Implement unique selection reduction #1194

luseverin wants to merge 42 commits into from
+143 −23

Conversation

@luseverin
Copy link
Collaborator

@luseverin luseverin commented Dec 10, 2025

Changes proposed in this PR:

  • Implement unique selection reduction and mean min max reduction with dim argument for forecast class

This PR fixes #1163

PR Author Checklist

PR Reviewer Checklist

luseverin and others added 30 commits December 8, 2025 15:10
@luseverin
Return impactForecast object in _return_impact
7da50f1
@luseverin
Return impactForecast object in _return_empty
bd3502f
@luseverin
Add full impactcalc test for impactForecast
dfa0198
@luseverin
Correct mistakes in _return_empty and _return_impact
59c0e5b
@luseverin
Raise value error when computing impact with impact forecast without …
4b5ae95 
…saving impact matrix
Cosmetics: Improve error message, move test to own class
9a516e1
@luseverin
Merge branch 'forecast-class' into impactCalc_block_nonsense_attrs
d571bb7
@luseverin
Merge branch 'impactCalc_return_impactForecast' into impactCalc_block…
6fe29f0 
…_nonsense_attrs
@luseverin
add test to check that eai_exp and aai_agg are nan for forecasts
899d8f0
@luseverin
Write nans for eai_exp and aai_agg when forecast is used
db32170
@luseverin
update tests using pytest
d2f035f
@luseverin
Fix error in test fixtures
c10a4b3
@luseverin
Returns nans for eai_exp and aai_agg when exposures is empty
d3a5642
@luseverin
add warning when at_event is used with forecast
d43a46c
@peanutfun
Update ImpactCalc tests for forecasts
e197566
@peanutfun
Merge branch 'impactCalc_return_impactForecast' of https://github.com…
0a324b2 
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
@peanutfun
Review ImpactCalc forecast handling
554cfc8
@luseverin
Block local_exceedance_impact
30ed14d
@peanutfun
Fix bug in test
f3ab44a
@peanutfun
Merge branch 'impactCalc_return_impactForecast' of https://github.com…
612a53c 
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
@luseverin
Block return_period and exceedance_freq_curve
9e4f2bb
@luseverin
Log warning for at_event getter
727357e
@luseverin
Add mean max min methods to impact forecast and tests
0bc5846
@luseverin
Merge branch 'forecast-class' into implement_mean_min_max
a55ab3b
@luseverin
Reduce lead time and member and update test
0aad2a5
@luseverin
Update docstrings
102f9be
@luseverin
Remove useless comments
dfce16f
@luseverin
Add min max mean for hazard forecast
0b6e1e4
@luseverin
Correct some mistakes in mean min max on hazard forecast
3fc25af
@luseverin
Add tests for hazard forecast mean min max
a4fe3b0
@luseverin luseverin marked this pull request as draft December 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

@chahank chahank Awaiting requested review from chahank chahank is a code owner

@peanutfun peanutfun Awaiting requested review from peanutfun peanutfun is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luseverin @peanutfun